Fix scroll regions across Dev Home #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
requested review from
dhoehna,
guimafelipe,
dkbennett,
EricJohnson327,
AmelBawa-msft and
bbonaby
krschau
force-pushed
the
user/krschau/scroll
branch
from
f717ebf
to
1d729d7
Compare
guimafelipe
approved these changes
Mar 19, 2024
EricJohnson327
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Moves scrollbars on all appropriate pages to the far side of the window
I would specifically like folks with pages I'm less familiar with to check that their flows look ok with this change (checking out the branch would be great). There was quite a bit of change in the SetupFlow and Environments areas and I wan to be sure I got every sub-page. @AmelBawa-msft @dhoehna @bbonaby
I tried to leave other code alone where I could (ie. replacing a StackPanel with an unnecessary grid so that everything inside of it wouldn't change indent in SetupFlow MainPage) but couldn't avoid it everywhere (all the indentation changes in SummaryView)
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist